Merged
Conversation
ryanschneider
requested review from
DaniPopes,
gakonst,
mattsse and
onbjerg
as code owners
3 tasks
klkvr
approved these changes
Dec 19, 2024
Member
klkvr
left a comment
klkvr
left a comment
There was a problem hiding this comment.
lgtm, thank you!
I kept the actual eip7742 module but am happy to delete that too.
yeah, we can remove this as well
klkvr
force-pushed
the
disable-eip7742
branch
from
6e07e4b to
875ec46
Compare
klkvr
force-pushed
the
disable-eip7742
branch
from
875ec46 to
8aea36d
Compare
MBerguer
added a commit
to MBerguer/alloy-zksync
that referenced
this pull request
Jan 8, 2025
keep up with alloy PRs - alloy-rs/alloy#1807 - alloy-rs/alloy#1828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With EIP-7742 pulled from Pectra this undos most of the changes in #1600, #1697, and #1713.
Solution
I kept the actual
eip7742module but am happy to delete that too.PR Checklist